Check out Symmetric Chess, our featured variant for March, 2024.


[ Help | Earliest Comments | Latest Comments ]
[ List All Subjects of Discussion | Create New Subject of Discussion ]
[ List Earliest Comments Only For Pages | Games | Rated Pages | Rated Games | Subjects of Discussion ]

Comments/Ratings for a Single Item

Earlier Reverse Order Later
Footer[Subject Thread] [Add Response]
🕸Fergus Duniho wrote on Sat, Oct 28, 2017 01:27 AM UTC:

For some reason, the footer is not showing up on .html pages, though it is working in php script. I'll have to look into this further tomorrow.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 11:51 AM UTC:

Footers started working in .html files after I started the session in each footer. But comments are displaying the date without the timezone, which suggests that the timezone is not being set.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 12:01 PM UTC:

Maybe it's just that commentsinc.php, which displays comments in the footer, is not using the Comment class used by listcomments.php.


H. G. Muller wrote on Sat, Oct 28, 2017 12:30 PM UTC:

Now that you mention a comment class: perhaps it would be a good precaution to protect comments from mutilating each other, now that people can use arbitrary HTML in them. I noticed that when I try to put an image in a comment with float:left style, it will protrude from the bottom (if the image is tall and there is little text), messing up the comment below it. I learned to prevent that now by putting the entire comment in a dummy 1x1 table; then the image just floats to the left of the table cell, and the cell will expand to contain the image, pushing the comment below it down, without messing it up. I don't know if there are more natural ways to confine formatting tricks to the comment that contains it, but it would in general be good if there was some isolation. So perhaps the comments should be formatted as 1x1 tables by default.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 02:17 PM UTC:

🕸Fergus Duniho wrote on Sat, Oct 28, 2017 03:33 PM UTC:

I partially fixed this with clear:both, and I completely fixed it with display:flow-root. But just in case the latter is not available in some browsers, I left in the former.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 03:49 PM UTC:

Even without setting display to flow-root, setting column-count to 1 fixes the problem. By using both, the problem should be fixed in browsers that support either one.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 03:55 PM UTC:

And overflow-y: hidden fixes the problem. By using all three solutions with the partial clear:both solution, it should be fixed in most browsers.


🕸Fergus Duniho wrote on Sat, Oct 28, 2017 07:29 PM UTC:

Adding <BR CLEAR=ALL> before the comment's footer stopped the footer from floating beside the image floated to the left, and it also solved the problem of the content invading other comments without any of the other solutions being set. But I put them back in for insurance.


🕸Fergus Duniho wrote on Sun, Oct 29, 2017 08:35 PM UTC:

The footer now uses the same Comment class as the listcomments.php script does.


🕸Fergus Duniho wrote on Thu, Apr 12, 2018 12:51 PM UTC:

I have made some changes to the footers. First of all, the Last Modified date was incorrect. It was displaying the timestamp of the footer file instead of the timestamp of the actual file. I changed this to display the ModifiedDate value from the database in a format that should be unambigious no matter how dates are formatted in your country. In addition to this, I added the value of CreationDate in the same format. Where there is an actual file, I added the timestamp of the file. This will differ from ModifiedDate when minor updates have been made without changing the ModifiedDate in the database, as well as when files have been copied without preserving the original timestamps. For Game Courier, I have added two more timestamps. One is the settings file timestamp, and the other is the log file timestamp. These will show up when such files exist.

I got the idea for some of this from the index/fileinfoinc.php script, which includes both Modified date from the database and the timestamp. I came across this script while updating scripts to use PDO methods instead of mysql functions. Since the important information it displays is contained in the footer, I will move it to an oldcode/ directory and stop including it in other scripts.


11 comments displayed

Earlier Reverse Order Later

Permalink to the exact comments currently displayed.