Comments by fhou

If we can make a tenjiku-set-view that can be used for chu shogi, it will have an important impact on the existing chu shogi model, but it's probably the right solution. At this stage, I don't know enough about tenjiku shogi to propose a sprites file in the right order (easier to manage promotions). But I've made a few attempts with icons  that could be used as a complement of yours.

sample 1 : chu shogi in bad order

sample 2 : chu seireigi in the right order

I like the duck, what was it used for?

Sounds good to me.

Do you have time to initialize the sprites file to make your icon choices at the moment? Is there any way I can help?

I agree :

-In the case of the Queen I would color the dots at the tips of the crown rather than a band near the -bottom; these look more like eyes.
-I would not work with upside-down pieces.
-I also think my Phoenix better fits in with the Wikipedia set than any of the possibilities shown in sample1.

The two pieces just before Leopard would make very nice Kirins, though; the leftmost probably fits better with the set (but the outline would have to be fattened).

→ May be we should keep the giraffe (the 1st is the dragon king of a skin in lishogi, the second was an attempt to make a kirin but not good enough)

The other is too detailed. The 'pumpkin' is a Fire Demon? The Lance gives too much suggestion of a diagonal move, IMO.

→We can keep the icones oj minjiku for consistency

I very much like the symbol for Go Between, and perhaps something similar should be used for Reverse Chariot. Was this the idea of having it in two sizes?
→ We could keep one the two (I didn‘t know which size was the best)

The Ox and Boar are nice (although the latter needs some fattening), but I still wonder whether it would not be better to use pieces with mnemonic value like a narrowed Queen's crown.

-->the idea is appealing, we can give it a try

bravo, that's really convincing. Of course, there are still some small details to be improved, but that can probably be done easily in a second phase (whale, some red dots ... ).

Here are a few links from lishogi if you need :

Chariot  Tiger  Rook-chariot

Regarding minjiku, I think the idea of having the same sword for the piece is a good one. It'll help you find your way around when you switch from one game to another.

attempt for a cart and whale :

I don't know enough about the game to have an opinion on these choices, but it sure becomes a lot more accessible this way. Note that there are several dogs available in the musketerchess editor if needed. I don’t know if you saw it : I posted yesterday a whale on a comment that may be a little better than the previous one.
Concerning the initialization bug of the selected player, I've noticed it too, not reproduced yet, I'll have to look in the code to see what's going on. A problem loading preferences?

Now that we've fixed the icons, we're ready for the next big step.

To finalize the pull request, we need to add game rules, and this is necessary for shogis anyway, especially for chu shogi.

I have made a draft of the rules for shogi, mini shogi and chu shogi which can be consulted here (select the game / buton rules on the top)

This could be a starting point for you if you find it useful, you can take them, rework them and put them on the pull request if needed.

The sources are here, it assumes though that you also use the same kind of sprites for shogis

By the way I saw this icon, I wondered if it could be used for the whale and the white horse :

.

I update the rules with trident

It comes from musketeerchess

If you want to use the trident and save some time : you can get the sprites here.

Changes :

-remove red dot between axes

-use trident instead of whale and white horse

-remove few pixels below the white fire demon

I'm sharing some sprite tests for a charioteer or lateral and vertical soldiers, I don't know if we still need them because we already have a satisfactory result :

tenjiku-set-view.js should probably use :

res/shogi/tenjiku-shogi-picto-sprites.png

instead of

/res/fairy/tenjiku-shogi-picto-sprites.png

?

concerning tenjiku, should the fire demon slide vertically? In wikipedia I have the impression that it's horizontally.

there was a refactoring on the last commit, wasn't there?

src/games/chessbase/res/fairy/tenjiku-shogi-picto-sprites.png     [deleted file]

Impact on tenjiku-set-view.js ?

thank you for the clarification I'm still learning...

I believe that the view-as bug comes from

jocly/examples/browser/js/control.js line 236

I think adding a test like could solve it. I didn’t dare doing it.

if(viewAs===undefined || Object.is(viewAs, null) || viewAs==="null")
      viewAs="player-a";

It probably comes from string like "xxxx.view-as": "null" in window.localStorage

I played Tenjiku Shogi and I encountered the following message : "Undeclared Zobrist array index -1 as param board"

You might reproduce it with the following game after attacking the black phoenix with the white fire demon :

Computer(B) level : strong

I think there's something odd about this particular case, because after the phoenix is taken, the black king is threatened.
This doesn't stop the black fire demon from attacking elsewhere and threatening the white king over the kirin. The fire demon doesn't have a flying diagonal, does he?
It's not the view-as bug, if you look at the local store ([f12]  then application tab in chromium), everything's normal.

if you right click on this link + select "save target as" : you shoukd be able to get the file tenjiku-chess-demon2phoenix.json on your disk

then select it from the load button and your browser should be able to initialize the game.

thanks for the explanation, I had a feeling it wouldn't be easy to solve.

I'm glad that this complicated problem has been solved. It seems a good idea to add a parameter in base-model to set to switch the search to king-capture mode in the pullreq branch.

the fact that you're experimenting explains the change in behavior when the fire demon attacks the king, which was resolved yesterday but no longer today.

that's not what I see, if I capture the Phoenix, at level Medium Jocly plays FD-d5 and start a cycle of attack against the white king.

But may be your personnal site is not updated yet?

Don't hesitate to add missing sprites if necessary.

Correct! It was a cache issue.