🕸Fergus Duniho wrote on Sun, Dec 11, 2016 03:34 PM EST:
In general, the name of the game should just be the name of the game, not anything else, such as "(rules enforcing)". You can save this for the settings name or mention it in the written rules. Looking over your code, I see that you did add a conditional for the Thronemate winning condition, but after it executes, the code proceeds to check for checkmate, stalemate, and the 50 moves rule, which could overwrite the game status. And this leads me to note an ambiguity in the rules. Is it legal for a King to move into check if the move will place the King on K8? In other words, does Thronemate override other conditions for winning? When programming the winning conditions, it is important to consider which conditions have priority over others. In general, it would be best to include all win, loss or draw conditions in a single series of if and elseif conditions. I did not do this in the preset you borrowed code from, but I did do it in my latest preset for playing Chess, which is called Chess3. I should convert the official Chess presets to it so that people will copy its code instead of older code.
In general, the name of the game should just be the name of the game, not anything else, such as "(rules enforcing)". You can save this for the settings name or mention it in the written rules. Looking over your code, I see that you did add a conditional for the Thronemate winning condition, but after it executes, the code proceeds to check for checkmate, stalemate, and the 50 moves rule, which could overwrite the game status. And this leads me to note an ambiguity in the rules. Is it legal for a King to move into check if the move will place the King on K8? In other words, does Thronemate override other conditions for winning? When programming the winning conditions, it is important to consider which conditions have priority over others. In general, it would be best to include all win, loss or draw conditions in a single series of if and elseif conditions. I did not do this in the preset you borrowed code from, but I did do it in my latest preset for playing Chess, which is called Chess3. I should convert the official Chess presets to it so that people will copy its code instead of older code.