Comments/Ratings for a Single Item

I have done it but not sure it is a good idea because if you use "view as player B". It won’t be correctly oriented.

I also updated the seireigi-sprites file one more time so that the promoted Kanjis are all facing the right way (you'll need to rename it to seireigi-shogi-sprites for it to have any effect on the biscandine site).

https://www.chessvariants.com/play/jocly/dist/browser/games/chessbase/res/shogi/seireigi-sprites.png

P. S. GIMP is awesome.

ok, taken into consideration

do you want me to replace the sprites Adam just sent for shogi on the pullreq branch?

Here is my updated version of your spritesheet. (For best results, clear browser cache before downloading)

I also took the opportunity to clean up stray pixels in your other shogi spritesheets.

www.chessvariants.com/membergraphics/MSchuseireigi/jocly-shogi-sprites.zip?nocache=true

I'll send you an updated pictogram spritesheet that you can use. Currently, the pictogram images still have the Kanji for the Kings since they are pulling from those locations.

The Wikipedia has it that the player with the weakest player has the Jade General, and the strongest player the King. I am not sure if and how we should implement that in Jocly.

I made the modification on my branch,

I'll wait to see if HGM wants us to do the same on the branch that will go into jocly.

It not clear to me, when there's an apostrophe, it's the general of jade that corresponds to the blacks, right?

In kanji sets, the player that moves first always has the King with the extra stroke. And it is true that the player who moves first is called Black (or Sente) in Shogi. It's just that in Jocly and the Mnemonic sets by H. G. Muller, the player that moves first has the white piece images by convention to make it easier for chess players.

you can also swap the 2d in the same *-set-view.js

It not clear to me, when there's an apostrophe, it's the general of jade that corresponds to the blacks, right?

You should only have to swap the King kanjis in the 2D Classic Seireigi sprites.

For the 3D pieces its as simple as swapping "sh-king" and "sh-jade" in the 3D piece definitions in the *-view.js files, so no problem there.

P.S. What I said above also applies to the Shogi Jocly implementations that use the King kanji on the biscandine site.

P.S.S. Also you have two extra rooks in your laser cutter SVG.

I use gimp. if the general of jade should be white (player a), it could be changed in seireigi-shogi-model.js

keep me posted I'll have to make the change too.

Thanks.

Out of curiosity, what program did you use to make the Seireigi Jocly sprites?

I am trying to fix a visual bug involving the 2d Kanji kings in Seireigi's implementation. The King with the extra stroke in the 2D Classic set is used for the player that moves second, when it should be used for the player that moves first.

Note that the SVG for laser cutting is updated with a rabbit.

Also the doc has been improved a bit in jocly.

The author, A. M. DeWitt, has updated this page.

Looks like it. I have uploaded the new version to the site and have adapted them so the implementation will work properly with the CVP files.

It should be ok now

Looks good, save for a few errors:

---------------------
Setup Errors
---------------------

White Kirin and Phoenix are swapped from where they should be in the initial setup

Black King and Great Elephant are swapped from where they should be in the initial setup

---------------------
Promotion/Drop Errors
---------------------

Lance, Running Rabbit, Knight, Gold General, and Great Elephant are currently allowed to promote immediately if they are dropped into the promotion zone (this should not be the case)

Both Pawns in the hand spaces can be selected when multiple Pawns are in the hand)

thanks for the advice.

I have modified accordingly

Should I add : Should I add " ##############" before and after?

Indeed, you should, because you want the extra hand ranks to be colored black as well.

19 is the size of handLayout

boardLayout :
0: "##............##" ​
1: "##............##"
​2: "##............##"
​3: "##............##" ​
4: "##............##" ​
5: "##............##" ​
6: "##............##"
​7: "##............##"
​8: "##............##" ​
9: "##............##" ​
10: "##............##" ​
11: "##............##" ​
length: 12

Should I add : Should I add " ##############" before and after?

Strange. 13 should be a valid index for an array of length 19. That means the array should have some internal elements that are undefined. What happens if you print

console.log( this.cbView.boardLayout )?

the array length is 19

NBROWS-row-1,row: 13, 0

Uncaught TypeError: this.cbView.boardLayout[((NBROWS - row) - 1)] is undefined

This sounds like an out-of-bounds access on boardLayout. Are you sure you defined that array with sufficiently many ranks? To further diagnose the problem you could add console.log(NBROWS-row-1); just before the access to boardLayout in paintCells; then you could see in the console  what the offending value is.