Comments by fhou

Jean-Louis confirmed that the patch solved the moves for Snake, Rhino and Sorceress.

Camel, Marshall and Canon remain to investigate.

That's fine with me.

I'll initialize a western skin2d with your sprites for the mini shogi. I'll send you a zip and let you commit it to make sure you're happy with it. That'll give you time to work on the movements and the missing pieces (samurai) ... if you're up to it.

Jean-Louis tested here :

http://biscandine.fr/variantes/test/examples/browser/control.html?game=bigorra-chess

Here is a draft for a western 2d skin with your sprites (you can retrieve for local checking or I can commit it if you find it more convinient)

You can see it here for : shogi and mini-shogi (select 2d western first)

Note that we will probably create a 2nd pull request after the big pull request we are doing.

So it will probably be possible to fix some icons and to comment some cbMoveMidZ functions later.

sorry for the inconvenience, I'll check and update

I've updated the link with the returned black pieces. Feel free to make any changes you like directly.

For me it's acceptable to have temporarily the promotion dialog that displays the kanji even in western mode. As far as I'm concerned, it's still understandable. Maybe we'll find a solution soon. I'd prefer to be able to play with this skin for beginners right from the start.

Congratulations for the 3d samurai.

I remove Griffin.png

It is better to refactor Squirle to Squirrel.

I prefer Griffon, I don’t know what is the best word in english.

I renamed the glidder in Huscarl because it reminded me of the Scandinavians who had axemen (vikings). But Yes we can refactor to axe ou axeman.

I will start to refactor Squirrel and axe.

PS : Is it allowed for the jumping general to go to the black line? same level as the brouhaha squares?

You are right, I think that zanzibar-s is also concerned since it is a metamachide variant

After a test, I can confirm that it works.

Check the jumping general in minjiku when there nothing between him and the black line. Not sure it behaves as he should

I was wondering if He can go to the black line like here for instance

Thanks for sharing gitpod. I didn’t know it.

You can start on your fork with a good idea, demanding a small coding ambition. You can always improve your skill, learning by doing.

If you succeed in doing what you wanted, you can propose it to lichess. Otherwise, I'm not surprised that it's hard to convince the developers, who are no doubt in great demand.

For the moment, I'm interested in jocly, maybe in a few months I'll look at lichess but more with the idea of providing them with a contribution than making a permanent fork.

You could also start a new branch just copying sources from https://github.com/fhoudebert/jocly/tree/trial It would squash everything in one commit while retaining your authorship on your shogivars.

I can also rebase my trial branch if it helps. I used to do it before always and stopped because it became fastidious.

in the meantime I'm going to overide cbCreatePromo in shogi-views because the alternative skin seem a must have for me for shogi

When I had conflicts, I usually replaced them with the original source, as they were binary files most of the time, so as not to make you lose your changes, even if it meant deferring mine. I'm sorry if I've made any mistakes, I'm not a git expert. Anyway, we shouldn't have to modify the same files anymore. Concerning the carriage returns I don’t know where it comes from since I have edited on linux only. Note my trial branch should contain all what is published on your branch.

For the promotion box in shogi, It is possible to use the sprites associated to the selected 2d skin

ex : shogi with 2d western

we don't need to redefine cbCreatePromo in the views concerned, a modification in base-view.js is all that's needed                                            

OK I wait for your branch.

I made a branch shogivars on my side on which I squashed branch trial, Because you are right some conflicts were not properly marqued as resolved. In case it helps :

https://github.com/fhoudebert/jocly/tree/shogivars/

Note that on github you can squash everything during the pull request resulting in one commit compliant with the master.

Is it really too late? If it's the right solution, maybe we should take it now or in the next pull request.

Perfect

You probably have locally

chu-shogi-view.js

chu-shogi-model.js.

They are not yet added to the branch